Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOLfYN Functionality #66

Open
rpauly18 opened this issue Oct 4, 2021 · 2 comments
Open

DOLfYN Functionality #66

rpauly18 opened this issue Oct 4, 2021 · 2 comments
Assignees

Comments

@rpauly18
Copy link
Contributor

rpauly18 commented Oct 4, 2021

Replicate DOLfYN IO functionality similarly to MHKiT-Software/MHKiT-Python#126

@Alex-McVey
Copy link
Contributor

Preference would be for pure Matlab (no wrapping python)

@simmsa
Copy link
Contributor

simmsa commented Jan 31, 2024

We are actively working on completing DOLfYN functionality.

High Level Progress:

  • Reading Files:
  • Coordinate System Conversion
    • dolfyn/euler2orient.m
    • dolfyn/orient2euler.m
  • Rotation (dolfyn/rotate)
    • Add rotation functionality
      • Track specific rotation functionality

PR #108 commit d29d5e3 adds the following:

Current code coverage indicates the following files have 0% code coverage:

  • dolfyn/adp/*.m
  • dolfyn/io/read_h5.m
  • dolfyn/io/write_netcdf.m
  • dolfyn/tools/bluewhitered.m
  • dolfyn/tools/dolfyn_plot.m

Dolyfn tests in MHKiT-Python that do not exist in MHKiT-MATLAB:

  • dolfyn/test_analysis
  • dolfyn/test_api
  • dolfyn/test_clean
  • dolfyn/test_motion
  • dolfyn/test_shortcuts
  • dolfyn/test_time
  • dolfyn/test_tools
  • dolfyn/test_vs_nortek

It may be the case that we do not need to add all of these tests, this is just for awareness and visibility.

@simmsa simmsa assigned simmsa and unassigned Alex-McVey Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants