Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Duplicate Hider's conditional/contextual Play Button #25

Open
Jordyn11 opened this issue Feb 14, 2023 · 3 comments
Open

Integrate Duplicate Hider's conditional/contextual Play Button #25

Jordyn11 opened this issue Feb 14, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Jordyn11
Copy link

Jordyn11 commented Feb 14, 2023

Requesting that the conditional play button is implemented into the theme allowing for the play button to display available sources for games where duplicate hider has hidden duplicates. The DH_Night Theme has implemented this as an worked example.

Screenshot from Dupe Hider Github here:
image

Further details can be found via the following xml example from Dupe Hider Github:
https://github.com/felixkmh/DuplicateHider/blob/master/UiIntegrationExamples/UiIntegrationDetailsViewExample/DetailsViewGameOverview.xaml

The specific use case I am looking to solve is to be able utilise duplicate hider to manage mame roms without having manually merge duplicates as this would allow duplicte hider to do the heavy lifting and then use the play button to select a specific version.

@MCC321-QC MCC321-QC self-assigned this Jul 2, 2024
@MCC321-QC MCC321-QC added the enhancement New feature or request label Jul 2, 2024
@MCC321-QC
Copy link
Owner

Put some time into this in version 3.6 but could not find a way to make it look like I wanted. Unable to set CornerRadius on the ContentControl of this extention. Will put more time into this on next update!

@Jordyn11
Copy link
Author

Put some time into this in version 3.6 but could not find a way to make it look like I wanted. Unable to set CornerRadius on the ContentControl of this extention. Will put more time into this on next update!

Nps. Appreciate the update and the efforts and happy to see you returning to the best theme on Playnite!

@MCC321-QC
Copy link
Owner

So I retried to integrate the "PlayButtonExt" control from Duplicate Hider like seen here and I got further with the integration but I ran into a problem. I was not able to fix it and it kind ruin everything even if it works, so I reverted the changes and this will have to wait again for another update, I may need to get help from the community for this one because I tried to integrate this in another theme and it worked perfectly so the problem come from eMixedNiteMC. Anyway Ive put way too much time on this (almost all night) so I will post the changes I made before reverting it so you guys can use the files and maybe help me find the solution.

Here is the problem
DuplicateHider PlayButton

Files to put in ..\Playnite\Themes\Desktop\eMixedNiteMC\Views :
DetailsViewGameOverview.xaml
GridViewGameOverview.xaml

File to put in ..\Playnite\Themes\Desktop\eMixedNiteMC\DefaultControls :
Expander.xaml

@MCC321-QC MCC321-QC added the bug Something isn't working label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants