Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP has reserved all method names with a double underscore prefix for future use #613

Closed
gnouet opened this issue Jan 15, 2019 · 3 comments
Assignees

Comments

@gnouet
Copy link

gnouet commented Jan 15, 2019

Hi,

PHP has reserved all method names with a double underscore prefix for future use.
There is five methods impacted :

  • __isAuthenticated
  • __toArray
  • __getMaximumSupportedVersion
  • __isAllowed
  • __getWWWAuthentificationString

If we rename all method to remove double underscore, it will introduce breaking change. But as it impacts interfaces, I do not see any good solution.

Is this a change that can be considered?
I did a little test that could become a merge request.

@gnouet
Copy link
Author

gnouet commented Jan 29, 2019

I created a PR in this sense. #616
Thanks for your feedback !

@Arul-
Copy link
Member

Arul- commented Feb 3, 2019

We need to apply this fix on RC5 and RC6 without affecting existing users on lower PHP versions

I'm still thinking about how to version this. I don't think we can call it RC5.1 and RC6.1

Also, Restler 6 is almost ready https://github.com/Arul-/reactive-restler/tree/dev

Once it is feature complete it will be released here.

Your ideas are welcome!

@Arul- Arul- self-assigned this Feb 3, 2019
@Arul-
Copy link
Member

Arul- commented Jul 19, 2021

Restler 4, and 5 (formally RC5 and RC^) won't have this change. Only restler 6 will have it

@Arul- Arul- closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants