You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out in Fix bugs in to_raman_shift #140 (comment), there is quite some duplicate code in the if/else statements of the axis conversion codes that can be consolidated.
It would be desirable to allow any cross-conversions between wavelength, wavenumber and energy (documenting in the metadata the conversions to warn if multiple conversions are done on the same axis). To this end, it may be considered to move the main part of the code into a generalized conversion function.
The text was updated successfully, but these errors were encountered:
As pointed out in Fix bugs in to_raman_shift #140 (comment), there is quite some duplicate code in the if/else statements of the axis conversion codes that can be consolidated.
It would be desirable to allow any cross-conversions between wavelength, wavenumber and energy (documenting in the metadata the conversions to warn if multiple conversions are done on the same axis). To this end, it may be considered to move the main part of the code into a generalized conversion function.
The text was updated successfully, but these errors were encountered: