Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility updates #45

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Accessibility updates #45

merged 4 commits into from
Jul 19, 2024

Conversation

sirkitree
Copy link
Collaborator

@sirkitree sirkitree commented Jul 18, 2024 •
edited
Loading

This resolves #37, #38, #39, #41, #42, and #44 which are all encapsulated by #25

@sirkitree
Resolves #37
112292c 
Add aria-label to the Get Started buttons on cover pages.
@sirkitree
Resolves #38
f7d2c63 
Add id and aria-labelledby to the nav.
@sirkitree
Resolves #39
2060563 
Add nav element to the arrow navigation with an aria-label
@sirkitree
Resolves #44 #41 #42
d2c7067 
- #41: Adds a hover state to the logo to turn red to black, similar to lullabot.com.
- #44: Adds in an alt tag to the image and an aria-label to the link.
- #42: Add visually hidden page callout to the page number in the sidebar.
huntermacd
huntermacd approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@huntermacd huntermacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sirkitree sirkitree merged commit f80b290 into main Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntermacd huntermacd huntermacd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get started buttons
2 participants
@sirkitree @huntermacd