Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Royalty payout split #197

Open
sk33z3r opened this issue Apr 5, 2022 · 0 comments
Open

Request: Royalty payout split #197

sk33z3r opened this issue Apr 5, 2022 · 0 comments

Comments

@sk33z3r
Copy link

sk33z3r commented Apr 5, 2022

Currently there is only 1 royalty address supported in the API.

Example json dump from nftDatas:

[
    {
        "nftData": "0x0352cf868450bf3f5a325c82b7cdda64a50cb9a2d7a722c6fdd83ee38956d6f0",
        "minter": "0x2758619dd2e45525b171410be5e12bfe1d056746",
        "nftType": "ERC1155",
        "tokenAddress": "0xE1f50B321E7d1B78c68EFA6241c2ee1117F67d62",
        "nftId": "0x86ba57a26070091df3fda8399731d9ba430f589a4aef233ed4f630f002d83161",
        "creatorFeeBips": 0,
        "royaltyPercentage": 0,
        "status": true,
        "nftFactory": "0xDB42E6F6cB2A2eFcF4c638cb7A61AdE5beD82609",
        "nftOwner": "0x2758619dd2e45525b171410be5e12bfe1d056746",
        "nftBaseUri": "",
        "royaltyAddress": "0x0F6EF4F04F14af17140d329C769F936776B4C36F",
        "originalMinter": "0x0F6EF4F04F14af17140d329C769F936776B4C36F"
    }
]

It's unclear from the docs if the minter sees any royalties when it's a different address, however some projects may have other requirements like more than 2 people receiving automatic royalties. Further, some projects may even require a split of those fees.

As a possible implementation, could there be an additional/optional field added to the contracts such that users can specify a list of addresses alongside a related list of percentages? During mint, the user would need to provide something like below.

In my example, there are 3 addresses specified to receive royalties.

  • 0x0F6EF4F04F14af17140d329C769F936776B4C36F would receive 25%
  • 0x0c0bbc2659a12B27e63208978087EDE339cb6a76 would receive 70%
  • 0xc94eCef4a14Bbe85A2A3Ce028D108b43FaAeA918 would receive 5%
[
    {
        ...
        "royaltyAddresses": ["0x0F6EF4F04F14af17140d329C769F936776B4C36F", "0x0c0bbc2659a12B27e63208978087EDE339cb6a76", "0xc94eCef4a14Bbe85A2A3Ce028D108b43FaAeA918"],
        "royaltySplit": [25, 70, 5],
        "originalMinter": "0x0F6EF4F04F14af17140d329C769F936776B4C36F"
    }
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant