Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with paginated explorer views #187

Open
sk33z3r opened this issue Mar 3, 2022 · 2 comments
Open

Issues with paginated explorer views #187

sk33z3r opened this issue Mar 3, 2022 · 2 comments

Comments

@sk33z3r
Copy link

sk33z3r commented Mar 3, 2022

Issue # 1: Transaction views have endless pagination

Repro:

  1. View a page of transactions with a short list (example transaction list)
    OBSERVE: Pagination nav indicates there are 4 or more pages
  2. Click the right arrow in pagination nav until you reach page 5

Expected:
Only 2 pages are actually available for the example transaction list.

Actual:
I am able to increment pages indefinitely.

Additional Notes:

  • This appears to only affect transaction views in the explorer. Viewing NFT collections typically shows the correct amount of pages in any collection size. However, see Issue # 2 below for other issues that occur with large collection views.

Issue # 2: Broken buttons exist in the page number navigation

There are odd behaviors in the pagination nav buttons as outlined below. I've color coded the image.

image

I've been using the loophead collection for testing.

  • Yellow - Operates the same as the < button, taking you to the previous page. Either this button needs to be removed for being redundant, or this button should bring up a menu of previous pages to jump to.
  • Green - This button does nothing. I would expect it to bring up a menu of more pages to jump to.
  • Pink - I added this box because I expect a >> button here that acts like the << button, but take you to the last page instead.

Issue # 3: NFT view stops at page 25

Repro:

  1. Open a wallet in explorer
  2. Click NFTs
  3. Click the >> button next to the NFT page buttons

Expected:
Goes to the last page of NFTs

Actual:
If the wallet has enough NFTs, it will stop at 25 and not show any more pages

Notes:

  • My wallet has 370 items in it, and the MetaBoy wallet has thousands. Both wallets are only able to reach page 25.
  • It appears this pagination is done in POST as I cannot force a page parameter in the address bar with GET. Other pages that are missing the ability to move onto further pages can at least be forced with GET (like the collection pages), but this page has no workaround.
  • Users can simply use https://lexplorer.io instead which now displays NFTs and does not limit the amount of pages.
@sk33z3r
Copy link
Author

sk33z3r commented Apr 5, 2022

Added a 3rd issue to the main ticket body

@shad-k
Copy link

shad-k commented May 15, 2022

These should be fixed with Loopring/loopring-explorer#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants