-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional support for decimal type #81
Comments
@nirmal82 We only just added Decimal support in v1.2.3 (https://github.com/LibertyDSNP/parquetjs/releases/tag/v1.2.3) If you upgrade to that release it should work! If it doesn't, then it sounds like we might have a bug. |
I am using the latest code. even while reading the parquet it generating some Buffer value instead of number/string. i am not good with javascript, so can you please help me to unblock with reading and writing parquet having DECIMAL datatype |
@nirmal82 could you share an example file that produces this issue? |
@wilwade attaching my sample parquet file and json data files both here are the steps
Thanks |
@nirmal82 I see that other readers work with it, but it doesn't appear to be supported. https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal Decimal is required to have precision <= 18, but this has it set at 38
|
Which now that I read it again, you said in your original post, I just missed it. |
Looked a bit more into it. So this library currently only supports up to 18 precision because it doesn't convert over that into the correct I'm not sure we would be able to do so without just using strings for the input and output due to the limitations of JavaScript working with big decimals. Open to ideas or PRs for sure! |
help needed
I am trying to generate parquet file with existing schema having field with following datatype
fixed_len_byte_array(16) LICENSE_TERM_IN_MONTHS (DECIMAL(38,0));
requesting for enabling support for this dataType
The text was updated successfully, but these errors were encountered: