Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error on training data from different format versions #152

Open
YodaEmbedding opened this issue Apr 10, 2021 · 1 comment
Open

Raise error on training data from different format versions #152

YodaEmbedding opened this issue Apr 10, 2021 · 1 comment

Comments

@YodaEmbedding
Copy link

YodaEmbedding commented Apr 10, 2021

Perhaps an error could be raised to warn if training data of different formats is mixed? It took me a bit to figure out why it was failing until I realized that the record sizes being read were varying.


EDIT: Hmm, using any non-v6 training data runs into problems since parse has v6_gen hardcoded into it:

    def parse(self):
        """
        Read data from child workers and yield batches of unpacked records
        """
        gen = self.v6_gen()        # read from workers
        gen = self.tuple_gen(gen)  # convert v6->tuple
        gen = self.batch_gen(gen)  # assemble into batches
        for b in gen:
            yield b
@teck45
Copy link

teck45 commented Apr 11, 2021

T60 since march 15 is 100 percent v6, 2 weeks before mostly v6 and around 10 percent v5 - needs rescoring.. t75 is 100 percent v6. Also some data can be corrupted. But overall I have good experience with late t60 data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants