-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Outdated celo dependencies #7551
Comments
aaronmgdr
added
bug
Something isn't working
libraries
Impacts the Libraries
triage
In need of triage
labels
Aug 8, 2024
aaronmgdr
added a commit
to aaronmgdr/ledger-live
that referenced
this issue
Aug 19, 2024
3 tasks
aaronmgdr
added a commit
to aaronmgdr/ledger-live
that referenced
this issue
Aug 22, 2024
This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it. |
this bot is hilarious |
aaronmgdr
added a commit
to aaronmgdr/ledger-live
that referenced
this issue
Sep 17, 2024
aaronmgdr
added a commit
to aaronmgdr/ledger-live
that referenced
this issue
Oct 14, 2024
This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it. |
hey still working on this. |
Wozacosta
pushed a commit
that referenced
this issue
Oct 24, 2024
Wozacosta
pushed a commit
that referenced
this issue
Oct 24, 2024
aaronmgdr
added a commit
to aaronmgdr/ledger-live
that referenced
this issue
Oct 24, 2024
Wozacosta
pushed a commit
that referenced
this issue
Oct 29, 2024
Wozacosta
pushed a commit
that referenced
this issue
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Impacted Library name
ledger live common
Impacted Library version
latest
Describe the bug
The short message is that ledger-live uses an old version of @celo/contractkit and needs to move away from that version to continue working.
Why?
Some history: When celo launched as an alt L1 it used a custom transaction type that like eth legacy was a type 0 but with extra parameters. we call this celo-legacy type. While the celo chain now supports eth-legacy, type 2 and celo’s specific cip64 (gas token) transactions, @celo/[email protected] only supports celo-legacy transactions.
But celo-legacy transactions are deprecated and the next hardfork will completely remove support for them. Furthermore because the chain will remove support, the latest celo-ledger-spender app only supports cip64 and eip1559 transactions making it already incompatible with ledger live. An unfortunate situation we were not aware of until recently.
When is the hardfork?
Uncertain for celo mainnet (2 months) but the alfajores testnet is moving to L2 status by end of September.
Wait What is the Hardfork?
I say hardfork but is bigger than that as CELO is becoming an OP based Layer 2.This is why the transaction type is being removed. It is not being backported to the new stack.
ledger-live/libs/ledger-live-common/package.json
Lines 123 to 127 in bc044e4
Expected behavior
upgrade to latest versions. eg 8.1.0 for celo/contractkit
The text was updated successfully, but these errors were encountered: