Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow URL inclusion? #1

Open
matejcik opened this issue May 28, 2024 · 1 comment
Open

Disallow URL inclusion? #1

matejcik opened this issue May 28, 2024 · 1 comment
Labels
question Further information is requested

Comments

@matejcik
Copy link

The more I think about it, the more I think it's a bad idea to allow inclusion of ABI or other information by (non-file) URL.

For one, this requires that the consumer has an Internet connection.

For two, and more importantly, content hosted outside the specfile* can change or disappear at any time. It is not possible to, e.g., sign over the spec, if it includes an external resource. Even if you add a checksum of the content at the time of creation, if the resource disappears, you can no longer reconstruct its contents and the spec becomes worthless.

*) what's a good term for the individual JSON descriptions? spec? specfile? descriptor?

@jnicoulaud-ledger jnicoulaud-ledger added the question Further information is requested label Nov 4, 2024
@jnicoulaud-ledger
Copy link
Collaborator

jnicoulaud-ledger commented Nov 4, 2024

Only valid points yes 👍 Relates to #2, for now our answer to this is that descriptors are snapshot/converted to resolved form at import time in our private/Ledger specific repository. It might be worth standardizing this part as all consumers/integrators will face this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants