From 1c570706f2e4faf9dc326706e6d6f127edbb246a Mon Sep 17 00:00:00 2001
From: Charles-Edouard de la Vergne <charles-edouard.delavergne@ledger.fr>
Date: Mon, 15 Apr 2024 13:00:38 +0200
Subject: [PATCH] Remove useless screenshots for test_legacy_contract, and
 simplify test

---
 .../nanos/test_legacy_contract/00000.png       | Bin 428 -> 0 bytes
 .../nanos/test_legacy_contract/00001.png       | Bin 419 -> 0 bytes
 .../nanos/test_legacy_contract/00002.png       | Bin 349 -> 0 bytes
 .../snapshots/nanosp/test_legacy_contract      |   1 -
 .../nanox/test_legacy_contract/00000.png       | Bin 587 -> 0 bytes
 .../nanox/test_legacy_contract/00001.png       | Bin 382 -> 0 bytes
 tests/ragger/test_sign.py                      |  17 ++---------------
 7 files changed, 2 insertions(+), 16 deletions(-)
 delete mode 100644 tests/ragger/snapshots/nanos/test_legacy_contract/00000.png
 delete mode 100644 tests/ragger/snapshots/nanos/test_legacy_contract/00001.png
 delete mode 100644 tests/ragger/snapshots/nanos/test_legacy_contract/00002.png
 delete mode 120000 tests/ragger/snapshots/nanosp/test_legacy_contract
 delete mode 100644 tests/ragger/snapshots/nanox/test_legacy_contract/00000.png
 delete mode 100644 tests/ragger/snapshots/nanox/test_legacy_contract/00001.png

diff --git a/tests/ragger/snapshots/nanos/test_legacy_contract/00000.png b/tests/ragger/snapshots/nanos/test_legacy_contract/00000.png
deleted file mode 100644
index c2420afe1d5b2ea19c999ee43f90c67f120d4f5b..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 428
zcmV;d0aN~oP)<h;3K|Lk000e1NJLTq004jh001Be0ssI2RY2!*0004VNkl<Zc%1E-
z(GG(k3`KRB|Np^0Y!5CBX(?!ti}9YA#jx5!k#_B-i4Z~v>CI>TUk!C8`c(mGx8WRa
z!xd`|I)kHai-|mfH_EU=@WQ<8?vt;iutXgsJ7fsT#RT=<c%5@2wgBi5Ku<u=_w=)-
z=Hv*17kUC9#_<01&<z;I`x7_>*@-kDbFv|(3aIfXRyfj@+?msfv|9!ih8`J$fW)Vn
zz~CO>;T|BN_mLd%e%vjPJ%D;eMaiRY#At6&Lsw*_J&nWB{N+Jii(`R~LM#+7vH7^1
zF{YKPgOW#*A8m0f)G#fTs8dpVu7-&qzkS-3oiTU-^*<9k78P5Y>WHD!W4f~aS-%if
z=ZR@VlnSwV`CZM!$c^HXr@$^f3+e?K9T@e1AEk+s4NtSE;t^;oLOod9f%9u_+g!V>
zg-|*Hr>)vEHnNj9aru-OX(LJU#UxzW#2tv5bk|2oN7xMoGovT4Cs$JRS3(FO58w+7
Wi7X{&VtL~L0000<MNUMnLSTYk@V+eo

diff --git a/tests/ragger/snapshots/nanos/test_legacy_contract/00001.png b/tests/ragger/snapshots/nanos/test_legacy_contract/00001.png
deleted file mode 100644
index b31e455967dd36ec248757eeb3ca37e26ae4def7..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 419
zcmV;U0bKrxP)<h;3K|Lk000e1NJLTq004jh001Be0ssI2RY2!*0004MNkl<Zc%1E;
z%?`sL2!QRfzW)RFupOFoOc6m*tmVrNi$6dGv9g8WIF92ymCa1^=KxmhYBEnzm+(mP
zIUw!5CO!!0fPOMz3(?!d7#?pc#RxDkqaa0NHfnKXe2(AeYJt7<cRJXMayY$1Fx>&Y
zgBND@G|SJC_g~fqbc0^sIaWU`>wufAelSi!%!3qtam)=vPiZv&K!Fpv#O{SmfokLJ
zp87upO%w<Z<kqo&dwlinaUa;@KCq{&4~o?S(Omw-sOG_EwTRSpK#Njh%-BV*y@=(i
zl>sYQqK)YLE>ZPF2NT+9(#mV<19*cgK44&97!^oMk`-llLWqi3*b+7J6;)f#rg;Z6
zj%lA#1coqYV>KeY%+@-9sUzLLDq<^u`9V=p<X3rRY0+xvFt#08>&V$8RXc!x+7OAG
zw)^arJc+=D-0$)sldm|!=|2NF`s5CFA)bPavHM@p0`xf59mjD7@&#R+4xnH^xfuWe
N002ovPDHLkV1g%Zy?y`y

diff --git a/tests/ragger/snapshots/nanos/test_legacy_contract/00002.png b/tests/ragger/snapshots/nanos/test_legacy_contract/00002.png
deleted file mode 100644
index ce795f34e8569e986af689fded3b59c9a8af2961..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 349
zcmV-j0iyniP)<h;3K|Lk000e1NJLTq004jh001Be0ssI2RY2!*0003bNkl<Zc%1E-
z%@V>O41}p;-~WL<=z+0=1Om1tEU@3H#qtw22}5*_5JCvC<NdnY@!SZf=bZ|_3uZeA
zzv<833;5lmZPyyZF7nH5k9&n;``2Wzni=OoMnLjeZ!G4b%5jQ~?Xiu3!v`aOym9=|
zFi%0P_sEMnjuPeqBy;Y<7zz;OoG=T?BQe()5gxob-#-pvr56zPj+vZs*7zvc)y3?k
z1aOLJy=-1h0GG6GZi4}#20ekxLQ8>o4!52c$FXo$VhXU?0M$^Bekqgf%Ka;M*^X|4
zEs9YCQ(xfJKmNC#+8dY%2&wT+>D^<3C%}<XbPeRMqt!t@kKPN&5dFP%@32VOA1?yV
v6+xZw{YDa!tAMG3nu5rL`0P&zA>_*k1^mvtO~`RE00000NkvXXu0mjf-kqOA

diff --git a/tests/ragger/snapshots/nanosp/test_legacy_contract b/tests/ragger/snapshots/nanosp/test_legacy_contract
deleted file mode 120000
index ab2ec19eaf..0000000000
--- a/tests/ragger/snapshots/nanosp/test_legacy_contract
+++ /dev/null
@@ -1 +0,0 @@
-../nanox/test_legacy_contract
\ No newline at end of file
diff --git a/tests/ragger/snapshots/nanox/test_legacy_contract/00000.png b/tests/ragger/snapshots/nanox/test_legacy_contract/00000.png
deleted file mode 100644
index 0446ee7541178d6fb0859fdf2bdc3ed0e9327a31..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 587
zcmV-R0<`^!P)<h;3K|Lk000e1NJLTq004jh002M;0ssI2U9{*Z0006KNkl<Zc%1E;
zTW-W43`J?xon-$@VlVwbMGP3@*yM4mdp<^)K#XOF*Ci<tLI@#*5JCtcgb<mWbI#dU
z`cA%|cEE!eWw_86z!GpAN4e<2UH{e!D1ap(NjboceoE=<X$PE)0}f*J6Jif2bm0b#
ze!@+_zX3G?vq=~Z$ON>r?rdFz0$u{fH4k(Sz!ET9apL9xECB^^&4arTB7_h^2q7Qj
zPwLI?!eS>_Az1%vuJWg~>xjE(2c7MQaX%4P%HF4KzTFM!hqrBg(NrlFjq6R1Mnsod
z<DDB~6SaQ%?e=}*7Cm}WG>$(>>I%z_GG=0?Wu7%|FO6H9*>t$kvXCN<Kei7eK;x3z
zRm)cz{vjyB*ySr?2S3XeBL&4(<Fh(Xig9AcY9;=N<-OY66=OhQ(F5GA>K-ez)0R&h
z+(wjXqnqTHlkhmnznv|ojBrPlkmmvaiFbV$G}}_#Z-fv+$W9_M)>6#SpSA2rEsbKc
zHvy4Gl{)ta-6KVeB4RBPCCTxoxHy?@d1gN7TCCCkR^V()OVKIK^`>o?QAAYg>qfSi
zZSUBX*QJwohwX%VK(J2yktOXbe8bms4$aP!0Am~C8B5%(gW17OkS?!2-IP*<A5n8X
ztDBzg0ruI(qAV(Aw<y3yk+OZ4?Pm$I#R&C}%h{;8atL~ucd4O3P;(`O5JCtcgb+eJ
Z`~sKBB>X=yxD@~Z002ovPDHLkV1ft<3IzZF

diff --git a/tests/ragger/snapshots/nanox/test_legacy_contract/00001.png b/tests/ragger/snapshots/nanox/test_legacy_contract/00001.png
deleted file mode 100644
index a58590b988714545e7960f7f400f360ffc5de41f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 382
zcmeAS@N?(olHy`uVBq!ia0vp^4M6O`!2~2@x4h6`U|@9hba4!+nDh2#bl+hG9*4k?
zQuR0Wo;SViCn%lTo!KM1<N4}TE=HcdggMMWO)#+9qVMtfuIo`d{@hvG5;?=H`J4LR
zwRaoWTYkD{&h=R9r~cmWo@*^`Jj~vB?S%04iSHX8Jugc%7w6q}S$9stD?W?s37h2d
zbN=6BQ=c)nX~}a9mamQzXUH}rox2+;#n5>sAjk5Y(@*V<VKX}7_iWu-zpq7l>#~<V
z>rbuHu`7A_H&AxgwHf8y4cdKvg$JbB4n%ez%sZ31aBYd&Oo@(7)_WJ(Znl2o8^PD`
zFE`_Y-IS+Kdq0Q2-7r_C=}F(5ev`U`H~)QH|9$1FHE$YjoVax+e0xei%S`SAGlOm!
zp7{T3NA-mVOYb&rdU8MdyIHo@@7cE*uj@I+Zu{2i)KMSV-E~o<g|+p~`n%k)uwY2g
YmzUY2z`9|^y+a@|Pgg&ebxsLQ0JeLtivR!s

diff --git a/tests/ragger/test_sign.py b/tests/ragger/test_sign.py
index 48a0fbe534..6b82cb238d 100644
--- a/tests/ragger/test_sign.py
+++ b/tests/ragger/test_sign.py
@@ -180,26 +180,13 @@ def test_legacy_chainid(firmware: Firmware,
 
 
 # Try to blind sign with setting disabled
-def test_legacy_contract(firmware: Firmware,
-                         backend: BackendInterface,
-                         navigator: Navigator,
-                         test_name: str,
-                         default_screenshot_path: Path):
+def test_legacy_contract(backend: BackendInterface):
 
     buffer = bytes.fromhex("058000002c8000003c800000010000000000000000f849208506fc23ac008303dc3194f650c3d88d12db855b8bf7d11be6c55a4e07dcc980a4a1712d6800000000000000000000000000000000000000000000000000000000000acbc7018080")
     app_client = EthAppClient(backend)
 
     try:
-        with app_client.send_raw(0xe0, 0x04, 0x00, 0x00, buffer):
-            if firmware.device.startswith("nano"):
-                # No screens recorded on Stax
-                moves = [
-                    NavInsID.RIGHT_CLICK,
-                    NavInsID.BOTH_CLICK
-                ]
-                navigator.navigate_and_compare(default_screenshot_path,
-                                               test_name,
-                                               moves)
+        app_client.send_raw(0xe0, 0x04, 0x00, 0x00, buffer)
 
     except ExceptionRAPDU as e:
         assert e.status == StatusWord.INVALID_DATA