Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Return rate limit details when returning grpc RESOURCE_EXHAUSTED code #845

Open
samlaf opened this issue Oct 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@samlaf
Copy link
Contributor

samlaf commented Oct 29, 2024

Use case and current behavior

Currently our disperser only returns a grpc RESOURCE_EXHAUSTED error, see for eg here.

However, this error code is returned for many different errors, including by the grpc framework itself:
image

Enhancement

We should add status details (see for eg https://jbrandhorst.com/post/grpc-errors/) so that clients can uniquely identify that they are being rate limited. We could also consider (if this information is available) returning as part of the details an approximate suggested amount of time that the client should wait before retrying in order to clear the rate limit.

Solution proposal

No response

Additional Information

No response

@samlaf samlaf added the enhancement New feature or request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant