-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Standard version of Typography #105
Comments
Is it Ok if I turn Typography.Contours to .NET standard project? |
I don't know. If this project targets .NET Standard, other projects, including the demo ones, cannot target .NET Framework 2.0 anymore. |
I would recommend using a shared project to share source code files between .NET Standard Class Library and .NET Framework 2.0 Class Library. And in the source code, using |
@zwcloud It is very hard to make another one of those for Typography.Contours though. |
Hah, that's actually introduced by me. Then just do it. @prepare :) BTW, |
Add .net standard support for Typography.Contours please check this b7cf599 is fit to your need? |
So Typography.Contours is a lower level of core Typography API. 😆 |
It is a very + dirty quick fix :) It needs more cleanup. Always welcome all suggestions + API design. |
the 'inner core' to 'outer' one => by order
other than those (eg. Contours) are not need. |
@prepare |
please see : 78b3bd7 (Also removed old Android and iOS project) Also update Android and iOS examples
DroidSans.ttf, iOS Emu, Xamarin + GLES2 surface DroidSans.ttf, Android Emu, Xamarin + GLES2 surface |
Android and iOS examples are 'just work' but not optimized yet I'm fixing it on the main PixelFarm project. |
One thing that I don't understand is why the .NET Framework 2.0-targeting build projects add files as link instead of referencing the shared project. Why add files in two places when you can do it with just one only? |
for VS2010 (old, with commercial license). |
Personally, I think it's better to drop support for VS2010. |
Yes, after I buy a new Visual Studio Professional :) |
Oh, ok. Thanks for replying. |
Why is Visual Studio 2017 Community not enough for you? ❔ |
Community Edition is fine for this project. But on another side, I can't use it to develop a software for an enterprise. (see: https://www.visualstudio.com/vs/compare/ |
I don't think you ever need to support an organisation this big. If the organisation does reach this big, it can probably afford Visual Studio Enterprise already. |
I don't think this issue should be closed as there are references to I would just simplify this to have everything target .net standard, and the "standard" version of .net standard to target is 2.0. (Unrelated to the 2.0 above!) It's not essential because .net standard 2.0 projects can reference .net framework 4.6.1 code, 99% reliably. But it would be cleaner. |
Hi @prepare, can you please also create .NET Standard versions of Typography.TextServices, TextBreak and TextFlow? I am planning to use them in CSharpMath. |
TextServices, TextFlow and TextBreak in the PixelFarm are more developed than in this repo. Give me a time to merge them back to this repo. |
.Net Standard version of TypographyIs now on dev branch. see: dbea27b But Porting back of TextServices, TextFlow, TextBreak are not finish, (Porting should be finish soon) |
.Net standard version is still 1.6 |
Now, move down to .net-std 1.3 |
Currently two files of this same type exists in two different places (PixelFarm.Typography and DrawingGL.Common). GlyphPathBuilder.cs, GlyphPathBuilderBase.cs and HintTechnique.cs should reside in the Typography.Contours project (as they should be proper APIs) and not hidden in the Demo projects.
I tried to move them but all of the projects rely on Typography.Contours targeting .NET Framework 2.0 and the mobile demo projects yelled at me. I tried to create Typography.Contours build projects like Typography.OpenFont and Typography.GlyphLayout but the reference errors are too much for me. Finally, turning Typography.Contours into a .NET Standard project to make every project happy results in
Welp, a day of work spent on nothing. I just wanted to make use of these files and follow the code in demos...
The same applies to a lot of types in demo projects that should be proper APIs.
The text was updated successfully, but these errors were encountered: