Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor Feature Request] Publishing of languages which will allow customization in the project #8

Open
azaricstefan opened this issue Aug 31, 2020 · 1 comment
Assignees

Comments

@azaricstefan
Copy link

Feature Request

What's the feature you think this package should have?

Respecting publish of language/languages in the project which will allow users to customize some language if needed. Currently ReviseOperationServiceProvider boot method look like below.

    public function boot()
    {
        // -----------> PROPOSED PLACE FOR LINE <--------------------------

        $this->loadTranslationsFrom(__DIR__.'/../resources/lang', 'revise-operation');

        // load views
        // - from 'resources/views/vendor/backpack/revise-operation' if they're there
        // - otherwise fall back to package views
        $this->loadViewsFrom(resource_path('views/vendor/backpack/revise-operation'), 'revise-operation');
        $this->loadViewsFrom(__DIR__.'/../resources/views', 'revise-operation');

        // Publishing is only necessary when using the CLI.
        if ($this->app->runningInConsole()) {
            $this->bootForConsole();
        }
    }

I guess we could allow user to customize the lang and add this line too?
$this->loadTranslationsFrom(resource_path('lang/vendor/backpack'), 'revise-operation');

Have you already implemented a prototype solution, for your own project?

Didn't had time to try it out.

Do you see this as a core feature or an add-on?

Minor feature.

@welcome
Copy link

welcome bot commented Aug 31, 2020

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

  • Bug Reports, Feature Requests - Github Issues (here);
  • Quick help (How do I do X) - Gitter Chatroom;
  • Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
  • Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

@azaricstefan azaricstefan changed the title [Minor Feature Request] Publishing of languages which will customization in the project [Minor Feature Request] Publishing of languages which will allow customization in the project Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants