Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Error on install #48

Open
jfelixoptimiumnc opened this issue Aug 22, 2022 · 8 comments
Open

[Bug] Error on install #48

jfelixoptimiumnc opened this issue Aug 22, 2022 · 8 comments
Assignees
Labels
bug Something isn't working Priority: SHOULD

Comments

@jfelixoptimiumnc
Copy link

Hi,

image

php artisan backpack:require:devtools

INFO Connecting to the Backpack add-on repository

│ Backpack repository entry is present in composer.json.
│ Backpack authentication token is present.

Require Backpack DevTools on dev .............................................................................. ERROR
│ For further information please check the log file.
│ You can also follow the manual installation process documented in https://backpackforlaravel.com/addons/

Thx for your help.

@pxpm
Copy link

pxpm commented Aug 22, 2022

Hey @jfelixoptimiumnc

Can you please check storage/logs/ and tell me what was logged there when this error happened ?

Cheers

@pxpm pxpm moved this to In Progress in This week Aug 22, 2022
@pxpm pxpm assigned pxpm and unassigned pxpm Aug 22, 2022
@tabacitu
Copy link
Member

Ouch! Thanks for reaching out.

Any chance you can follow the manual process here, you should get a more specific error message, at the very least?

https://backpackforlaravel.com/products/devtools

@jfelixoptimiumnc
Copy link
Author

Hi Christian,

Indeed, sorry did not see the manual procedure. It works.

The point is that I use "composer.phar" on the root folder so i guess the auto procedure fails (confirmed from the logs).

Thx for your quick help.

Best,

@tabacitu
Copy link
Member

tabacitu commented Aug 23, 2022

Damn... composer.phar - that's right, we didn't take that into account... Thank you @jfelixoptimiumnc 🙏

Can we take that into consideration when we run composer commands @promatik ? Options:

  • (a) I believe Laravel runs commands with app()->composer() like it does app()->artisan() - we could use the same;
  • (b) we could check if composer command exists before calling it? then check composer.phar? or maybe we echo an error message that's clearer if we detect this problem? something like "Composer command not found. Please run the manual installation procedure for this addon, as outlined in the docs."

@maurohmartinez
Copy link
Member

@tabacitu I am not that familiar with the installation process and it is taking me long to get my head around it. I don't have a problem to invest more time, but I just figured out that maybe you have someone else who can take over this? Or I can research a bit more until I can do it. Let me know!

@tabacitu tabacitu assigned pxpm and unassigned tabacitu Nov 26, 2022
@tabacitu
Copy link
Member

Good thinking @maurohmartinez . @pxpm any insight into this?

@pxpm
Copy link

pxpm commented Nov 28, 2022

@tabacitu from my research I think it's safe to use app()->composer() since they have a "search composer" function that will look for the .bat fille.
https://github.com/laravel/framework/blob/11edbfee376a3822911d9df1044c618eb584dce6/src/Illuminate/Support/Composer.php#L68

@tabacitu
Copy link
Member

Awesome. Yeah, then let's do that!

@tabacitu tabacitu added bug Something isn't working and removed Priority: COULD labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: SHOULD
Projects
Status: Todo
Development

No branches or pull requests

5 participants