Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

Clean up reaction bottom sheet #135

Open
tabeckers opened this issue Feb 8, 2021 · 1 comment
Open

Clean up reaction bottom sheet #135

tabeckers opened this issue Feb 8, 2021 · 1 comment
Labels
Type: Enhancement Not a feature, but will improve the product in one way or another.
Milestone

Comments

@tabeckers
Copy link
Contributor

The current reaction bottom sheet uses a BottomSheetBehavior. It has a peek_height to allow it to be swiped up. Because we want the peekheight area to also be filled with reaction items, the bottom sheet has a height that is larger than the screen. The CoordinatorLayout in which it exists pops up above the screen border so the bottom sheet can slide up until the peek height area is above the screen. As a result the entire area we wish to display reactions in will be filled with reaction items.

Another issue is that the bottom sheet can be swiped down to be removed. If we detect a state change to STATE_HIDDEN, we simply push it back up again so the peek height area is visible again. If we don't do this, we aren't able to swipe the reactions up again after swiping down the peek area.

@tabeckers tabeckers added the Type: Enhancement Not a feature, but will improve the product in one way or another. label Feb 8, 2021
@tabeckers tabeckers added this to the 1.1 milestone Feb 8, 2021
@tabeckers
Copy link
Contributor Author

Note: the animation sometimes jumps.

@tabeckers tabeckers removed this from the 1.1 milestone Mar 8, 2021
@tabeckers tabeckers added this to the Backlog milestone Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement Not a feature, but will improve the product in one way or another.
Projects
None yet
Development

No branches or pull requests

1 participant