Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check how (or if) radial bin edges are propagated to the cluster ensemble profile #628

Closed
combet opened this issue Jul 16, 2024 · 2 comments · Fixed by #631
Closed

Check how (or if) radial bin edges are propagated to the cluster ensemble profile #628

combet opened this issue Jul 16, 2024 · 2 comments · Fixed by #631
Assignees

Comments

@combet
Copy link
Collaborator

combet commented Jul 16, 2024

Currently it seems we have the bin edges information for single profile but this information seems to be lost when saving the individual profiles in the cluster ensemble. Need to look into it.

@hsinfan1996
Copy link
Collaborator

Only "radius" is there, and "radius_min" and "radius_max" are not, so yes, we lost the information on the bin edges.
Not sure if it is what you want, but adding "radius_min" and "radius_max" to tbcols in this line is a way to retain the bin edge info.

tbcols = ("radius", tan_component, cross_component, weights)

@m-aguena
Copy link
Collaborator

Only "radius" is there, and "radius_min" and "radius_max" are not, so yes, we lost the information on the bin edges. Not sure if it is what you want, but adding "radius_min" and "radius_max" to tbcols in this line is a way to retain the bin edge info.

tbcols = ("radius", tan_component, cross_component, weights)

that is the exact idea here

@m-aguena m-aguena self-assigned this Jul 16, 2024
@hsinfan1996 hsinfan1996 linked a pull request Jul 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants