Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the cliendWidht before accessing it #3

Open
murilohpucci opened this issue Apr 5, 2024 · 1 comment · May be fixed by #4
Open

Validate the cliendWidht before accessing it #3

murilohpucci opened this issue Apr 5, 2024 · 1 comment · May be fixed by #4

Comments

@murilohpucci
Copy link

Hey! It's great to see superfish was forked and now maintaned, I have a tiny improvement for the supersubs.js file, on the line 39 we are initializing the variable size, but we don't validate if the clientWidth exists, and we do not initialize the variable properly, this led us to some console errors.
murilohpucci pushed a commit to murilohpucci/drupal-superfish that referenced this issue Apr 5, 2024
Initialize the size variable and validate the clientWidth
330e574 
Fixes: LOBsTerr#3
@murilohpucci murilohpucci linked a pull request Apr 5, 2024 that will close this issue
Open
@murilohpucci
Copy link
Author

Besides this issue, I have created one issue on the drupal module
https://www.drupal.org/project/superfish/issues/3438781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize the size variable and validate the clientWidth murilohpucci/drupal-superfish
1 participant
@murilohpucci