Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Problems when moving floating windows with mouse between monitors #1065

Open
alex-ds13 opened this issue Oct 17, 2024 · 2 comments · May be fixed by #1075
Open

[BUG]: Problems when moving floating windows with mouse between monitors #1065

alex-ds13 opened this issue Oct 17, 2024 · 2 comments · May be fixed by #1075
Assignees
Labels
bug Something isn't working

Comments

@alex-ds13
Copy link
Contributor

alex-ds13 commented Oct 17, 2024

Summary

Currently when using the mouse to move windows, komorebi only checks to start a move operation if the origin workspace is tiling and it checks for the focused container so if we move floating_windows or if we move a window from a floating workspace the MoveResizeStart event won't create a pending move operation or it will create a wrong one (in the case of floating_windows).

Then moving this windows back can create problems.

In the case of the floating_windows nothing bad seems to happen and it is all ignored, although the window never gets transferred to the other monitor on komorebi as it should...

The worst thing is when moving from a floating layout since that won't create a pending move, the window won't be transferred however when moving back, since now the origin workspace will be tiling it will create the pending operation but with the focused container which will be the container that already existed before on that workspace, which results on komorebi transferring that window to the other monitor, however this only happens on komorebi since the target workspace is now a floating workspace it's update function won't move the window from the other monitor and it stays there looking like it is were it was before but unmanaged, when in fact it is now owned by the floating workspace and the only way to fix it is to manually move it with mouse to the floating workspace and then use a keybind/command to move it to the tiling workspace again...

Version Information

This happens on 0.1.29 and even on master...

Komorebi Configuration

(Can I leave this emtpy?! :P )

Hotkey Configuration

(Can I leave this emtpy?! 😅)

Output of komorebic check

(Can I leave this emtpy?! 😅)

@alex-ds13 alex-ds13 added the bug Something isn't working label Oct 17, 2024
@alex-ds13
Copy link
Contributor Author

@LGUG2Z I've already seen where the problem is and have some ideas to fix it. If you want you can assign this to me!

@alex-ds13
Copy link
Contributor Author

This issue was first brought up on this discord support thread.

Another related issue was found there where using the move-window commands to a direction where it ends up moving them to another monitor or workspace also misbehaves if the target workspace is not tiling (floating mode). I'll have this one on a different PR.

I'm adding this comment here so I don't forget about this later... 😅 @LGUG2Z If you want me to instead open another issue for this one, I can do so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant