Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Bar - Show all processes assigned to workspace (Icons / Text / Both) #1013

Open
patrikzudel opened this issue Sep 30, 2024 · 11 comments
Labels
enhancement New feature or request i-will-not-work-on-this I'm not going to work on this, but someone else is welcome to komorebi-bar Related to the komorebi-bar crate

Comments

@patrikzudel
Copy link

Most intuitive way for me to use a TWM is to have the Bar actively show what Process is in which Workspace.
Showcased below is my simplistic implementation in Zebar.
bar

I'd like to propose a new feature for Komorebi Bar:

  • Allow showing the Icons || Names of all processes in each workspace next to the workspace name.

There should be 3 options for this setting:

  1. Formatted Process Name (Capitalize first letter, replace [ - , _ ] symbols with space and remove .exe) [ Same as in Picture Above ]
  2. Only the process Icon
  3. Icon + Formatted Process Name

We've originally talked about this feature a month ago in your YT comments, I've seen that @LGUG2Z already made progress on the icons, GJ!!!!

@patrikzudel patrikzudel added the enhancement New feature or request label Sep 30, 2024
@xidsyed
Copy link

xidsyed commented Oct 2, 2024

sorry but i have to know, what font is that?

@patrikzudel
Copy link
Author

sorry but i have to know, what font is that?

Fira Code

@LGUG2Z
Copy link
Owner

LGUG2Z commented Jan 23, 2025

I think that this has been implemented now, right @CtByte ?

@LGUG2Z LGUG2Z added the i-will-not-work-on-this I'm not going to work on this, but someone else is welcome to label Jan 23, 2025
@CtByte
Copy link
Contributor

CtByte commented Jan 23, 2025

The workspace widget can show focused apps with icons, but not all open apps.

Displaying app names can be complicated, as the info we have is just the executable's name right now and I think the title is better in most cases.

For example visual studio's exe is devenv.exe, which would not really be descriptive as Devenv. You can check this info with the komorebic visible-windows command.

@patrikzudel Would #1141 and #1176 satisfy your needs? 🤔

Image

@patrikzudel
Copy link
Author

patrikzudel commented Jan 23, 2025

Trying it right now! Is it possible to show icons of all the programs present in a workspace?

Currently, only the focused window is shown despite the workspace having 3 programs, is this expected behavior?

Image

From this image from #1141 I figured there should be a way to show all programs in the workspace but can't make it work :/
Image

My config (ver: commit_hash:77ef259e)

"left_widgets": [ { "Komorebi": { "workspaces": { "enable": true, "display": "Icon", "hide_empty_workspaces": false }, "layout": { "enable": false }, "focused_window": { "enable": false, "show_icon": true } } } ],

@CtByte
Copy link
Contributor

CtByte commented Jan 23, 2025

@patrikzudel

The workspace widget can show focused apps with icons, but not all open apps.

yes, only focused "containers" are shown. I forgot to mention here that if you stack windows then indeed you can see multiple icons. I currently do not use the "first version" of the stackbar as the bar will show it nicely.

Image

@patrikzudel
Copy link
Author

@CtByte I see, the plural used in that sentence made me unsure.

Great addition! But for my use cases seeing all the processes / "containers" in a workspace is the priority at the moment :/

Would you consider adding that? Thank you for your work so far!!!!!

@CtByte
Copy link
Contributor

CtByte commented Jan 23, 2025

@patrikzudel Ah I can see the confusion.

The challenge is how to show all the apps on a workspace if there are stacks as well 🤔 Perhaps there can be a setting on the widget that lists all the apps (not only focused) and separate them by a | like it is on the network widget

Image

This might be enough to separate the icons, so

stack = ()
app1 | (app2 app3) | app4

What do you think? (I do not have much time to develop right now, but I can put this on my todos 🙂 )

@patrikzudel
Copy link
Author

patrikzudel commented Jan 23, 2025

Previously, I used spacing differences in my implementation.

Firefox Cmd Notepad Discord

Here, the distance between containers is 3X the distance between icons in a stack. Even 2X might be good.

But frankly, I think even if we wouldn't differentiate stacked processes, it would be sufficient. The main utility is being able to figure out what processes are within a workspace at a glance. It would also save space and retain the minimal aesthetic.

@CtByte
Copy link
Contributor

CtByte commented Jan 23, 2025

Let's see how it looks with spaces and | or even , . I will try to ping you when there is a PR 🙂

@LGUG2Z
Copy link
Owner

LGUG2Z commented Jan 23, 2025

Unrelated: @patrikzudel if you could share komorebi with your sizeable audience that would be cool 😅

@LGUG2Z LGUG2Z added the komorebi-bar Related to the komorebi-bar crate label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i-will-not-work-on-this I'm not going to work on this, but someone else is welcome to komorebi-bar Related to the komorebi-bar crate
Projects
None yet
Development

No branches or pull requests

4 participants