-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison of the results of pyWinCalc and WINDOW #25
Comments
I have the same issues. |
@christoph-maurer and @Fan-Feng We are aware that some of the results are not exactly the same but they are close enough. As for BSDF, that is currently under examination since we have realized that WINDOW is not doing wavelength by wavelength calculation correctly. We are currently working on consolidating procedure between two engines for BSDF case. |
Can I please revive this issue to ask if there is any documentation or commentary about the differences in calculations between TARCOG and WinCalc so I can understand them better? I am trying to validate pyWinCalc results against WINDOW simulations and I would like to understand the points of difference. I am familiar with the technical documentation for WINDOW which I assume describes the TARGCOG method. Sample differences: |
@RebeccaPowles I can help you with that. I see above that you have compared two IGUs that have only clear glasses. The difference in the U-value is way too much. NOTE: All results that I am presenting are output of the Windows-CalcEngine unit tests. However, they should match with what you are running in pyWinCalc. We have issues for most of these in Windows-Tools repository for which we have to give you an access (which can be done). However, I can try to explain some of the differences here. The above results are obtained with full spectral data and Non-BSDF case. I have also run NFRC 102-103 with BSDF Quarter Basis: So as for clear glasses, you should be getting similar differences. When you wrote 4Clr/8Air/4Clr, what is the glass (NFRC ID) that you were using? As for general differences I found out the following: One more thing that you sholud be aware of is this: Additional note for you. In previous weeks I was working on validating shading devices vs WINDOW and found some problems that are fixed. However, that version is still not available in pyWinCalc but we are hoping to release it soon. I am still trying to catch time and do additional comparison of various shading devices but had to divert to different project at this time. |
Thanks, @vidanovic -for now I am just checking specular glazing. I thought the difference was surprisingly large which is why I thought there would be an explanation. Here is what I am doing: Case 1: Set in preferences: Simulation Engine : Tarcog Ufactor = 2.941 (I confirmed this is the value from earlier WINDOW versions as well) Using pyWinCalc, I get U= 2.954, matching the WINDOW WindowsCalc-Engine result but not the Tarcog / earlier WINDOW versions result. Hmm... OK - maybe it is something weird with layer 9706 as if I change to 9705 or 9707 there is no difference between the two Ufactor results. Looks like I just got lucky with the layer I chose to start testing with. As you suggested - it is the case that layer 9706 has data up to 25 micrometers and 9705 and 9707 only have data to 2.5. But why is there such a large difference? The emissivity of 9706 according to pywincalc is 0.845/0.846 (default value for uncoated glass is 0.84) If I delete the IR spectral data and use these values for precalculated emissivity, I get U=2.954, which is consistent. U is sensitive to the emissivity values. So are these emissivity values 'real'? option 2 - There is a bug in the emissivity calculation and the values should be closer to the precalculated value of 0.84 - unlikely, I know you have tested but it never hurts to recheck If it turns out to be option 3 - I understand some reasons why you might want to prioritise spectral data, but these differences in UCOG are pretty large - . These deviations could occur for any database layer with IR data if there is a difference between the precalculated values and the spectral data. It is not possible for 'regular' WINDOW users to see which database layers have IR data to note where these differences may appear. To manage this it could be useful to have the option to continue to use the precalculated emissivity values - this option could be made accessible through WINDOW preferences. That way you could expect good agreement across WINDOW versions and pywincalc for all database layers with the appropriate options selected, but it will still be possible to use the spectral data when required. |
@RebeccaPowles I am guessing that somewhere in the process there is something like this: |
My guess is that WINDOW/tarcog prioritizes the precalc value coming from the header value (0.84) and pyWinCalc prioritizes the spectral data. We have tried to make everything consistent that the spectral data has highest priority in all cases (since that is the only way you know that you are calculating the emissivity according to the standard you are expecting). The old world always involves two steps of sleuthing, 1. Figure out what data in the file was used - {Emissivity}, {Material}, or spectral data, and then the second step if the precalculated value is used or if a new emissivity is calculated according to the selected standard. Exporting 9706 from Optics gives a header that suggests the spectral data is ignored in IGDB. |
@jcjonsson WINDOW is definitely taking header values over the integration. Also, I am guessing about rounding since 0.84 is such a round number :) |
I would recommend doing nothing about this in WINDOW 7.8. As W8 starts reading directly from IGSDB and checker tool rejects emissivity that is not consistent with IR data, this will take care of itself. The question is what to do with existing data, which may require going through database with checker tool. |
Thanks @vidanovic and @jcjonsson for your comments - now I understand what is going on I am happy to manage it in my own code for now. Enjoy your holiday break. |
Thanks @rebecca Powles ***@***.***>. Enjoy your Summer break.
Charlie
…On Wed, Dec 11, 2024 at 2:34 PM Rebecca Powles ***@***.***> wrote:
Thanks @vidanovic <https://github.com/vidanovic> and @jcjonsson
<https://github.com/jcjonsson> for your comments - now I understand what
is going on I am happy to manage it in my own code for now. Enjoy your
holiday break.
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJULFAICHWF2PEDK3LULRL2FC4WPAVCNFSM6AAAAABTKCP3BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGMZTSNZVG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
-------------------------------------------------------------------------------------------
D. Charlie Curcija, Ph.D. Tel: (510) 495-2602
Lawrence Berkeley National Laboratory Fax: (510) 486-4089
Windows & Envelope Materials Group Cell:(510) 604-8668
1 Cyclotron Rd., 90R3147 Email: ***@***.***
Berkeley, CA 94720 Web:
http://windows.lbl.gov/ <http://btech.lbl.gov/>
-------------------------------------------------------------------------------------------
|
I have cloned https://github.com/LBNL-ETA/pyWinCalc and run five examples. Then I have modeled these five glazing systems in WINDOW 8.0.6.0 and compared the results to the results of pyWinCalc. I found good agreement for the examples single_clear.py and triple_clear.py. I was not able to reproduce the results of igsdb_double_clear.py, interior_bsdf.py and igsdb_interior_bsdf.py in WINDOW.
I attach the five glazings systems as a WINDOW database, screenshots of the settings and the files of the comparison. How can I reproduce the examples from pyWinCalc in WINDOW?
comparison_pyWinCalc_WINDOW.zip
The text was updated successfully, but these errors were encountered: