Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kunena Latest] Conflict with language codes (part 2) #316

Open
rich20 opened this issue Sep 7, 2024 · 2 comments
Open

[Kunena Latest] Conflict with language codes (part 2) #316

rich20 opened this issue Sep 7, 2024 · 2 comments
Labels

Comments

@rich20
Copy link
Member

rich20 commented Sep 7, 2024

Step 1. Please change in mod_kunenalatest.xml line 154

label="MOD_KUNENALATEST_PARAM_CATEGORYLIST_NONE" multiple="true" size="5">

from
label="MOD_KUNENALATEST_PARAM_CATEGORYLIST_NONE" multiple="true" size="5">
to
label="MOD_KUNENALATEST_PARAM_CATEGORYLIST" multiple="true" size="5">

Step 2. Remove line 62 in en-GB.mod_kunenalatest.ini

MOD_KUNENALATEST_PARAM_CATEGORYLIST_NONE="All / None"

and add these 2 strings instead
MOD_KUNENALATEST_PARAM_CATEGORYLIST="Category list"
MOD_KUNENALATEST_PARAM_CATEGORYLIST_ALL="All categories"

The result is somewhat clearer (see image). In this example, all categories are hidden.
.
Bildschirmfoto vom 2024-09-06 20-17-20

@Pinkeltje
Copy link

Pinkeltje commented Sep 9, 2024

In this example, all categories are hidden.

In my test (with proposed changes) all categories are not hidden. Furthermore I don't think it makes sense to have an option to hide all categories. If you hide all categories there is no use in using the module.

@rich20
Copy link
Member Author

rich20 commented Sep 9, 2024

Not all categories are hidden even without these changes. For this suggestion I have only changed the text. But hiding does not work for individual categories either, which is why I have also created this ticket. #317
I don't want to judge whether it makes sense to hide all categories, as it has always been like this with All / None (display or no display).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants