fix(ai): fix Azure streaming with raw JSON transmission mode #14148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
tysoekong
force-pushed
the
fix/ai_azure_streaming
branch
from
6f19595 to
bd4ad6e
Compare
tysoekong
requested review from
fffonion,
liverpool8056,
oowl and
AntoineJac
and removed request for
fffonion
fffonion
reviewed
Jan 14, 2025
oowl
approved these changes
Jan 14, 2025
|
@fffonion The tests already cover the case, but for some reason started failing. I think something changed in chunked requests in some backport. It's working fine now. I mean: it's tested by the integration suite for AI Gateway. |
|
I start looking the code. LGTM but for info I never manage to replicate the issue on Azure... |
|
due to timeline, will add unit test after merged. |
fffonion
approved these changes
Jan 15, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Azure streaming when "JSON mode" is used (i.e. when inline content safety is enabled).
It broke because the SSE chunk would start with
[or'and be caught by the wrong switch statement in the parser.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6419