Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine test plan #7

Open
rainest opened this issue Nov 9, 2023 · 1 comment
Open

Determine test plan #7

rainest opened this issue Nov 9, 2023 · 1 comment

Comments

@rainest
Copy link
Contributor

rainest commented Nov 9, 2023

Existing deck integration tests generally rely on the CLI. This repo will not have that CLI readily available, and will need some changes to its testing strategy.

Offhand, I'd expect the simplest option is have the test actions here check out a copy of the deck repo main, update its go.mod to use the PR head commit as the current version of this library, and run deck's usual test suite. This approach will probably hit chicken-egg problems where coverage for this repo relies on features that aren't yet merged into deck main. Unsure how to best handle that, but we can maybe add a variant of tests that lets you choose the downstream branch and still satisfies the same Actions status.

@rainest
Copy link
Contributor Author

rainest commented Nov 15, 2023

#10 is the most basic option for this. It reuses existing tests by importing deck as a test dependency here.

This generally works, though creates a (test only) dependency chain that's a bit silly. To avoid it we'd need to implement some sort of alternate to the client code, that invokes the sync/diff functions here without either of the downstream consumers (deck and KIC) of this library.

@pmalek pmalek mentioned this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant