Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deck dump is missing consumer-group association when listing consumers. #1483

Closed
Prashansa-K opened this issue Jan 7, 2025 · 0 comments
Closed

deck dump is missing consumer-group association when listing consumers. #1483

Prashansa-K opened this issue Jan 7, 2025 · 0 comments
Assignees
@Prashansa-K

Comments

@Prashansa-K
Copy link
Contributor

We seem to have a regression in deck gateway dump in 1.42.0. It is missing the consumer group association (groups.*.name) under consumers.

decK v1.41.4 (4da4246)

❯ deck gateway dump
_format_version: "3.0"
consumer_groups:
- name: gold
consumers:
- groups:
  - name: gold
  username: alice

❯ deck version
decK v1.42.0 (63fd4c7)

❯ deck gateway dump
_format_version: "3.0"
consumer_groups:
- name: gold
consumers:
- username: alice
@mheap mheap mentioned this issue Jan 7, 2025
Merged
Prashansa-K added a commit to Kong/go-kong that referenced this issue Jan 8, 2025
@Prashansa-K
fix: added new method to fetch a consumer-group without consumers.
ddd9227 
Reverted the existing `Get` method to keep listing
consumers and added a new one that uses the query
parameter `list_consumers=false` to skip listing
consumers for performance reasons.
This is done so as to fix dump errors coming in
deck when using gw 3.9+ where consumer-groups
do not show the associated consumers. We will
push the performant option behind a flag.

For: Kong/deck#1483
@Prashansa-K Prashansa-K mentioned this issue Jan 8, 2025
Merged
Prashansa-K added a commit to Kong/go-kong that referenced this issue Jan 8, 2025
@Prashansa-K
fix: added new method to fetch a consumer-group without consumers.
a067cec 
Reverted the existing `Get` method to keep listing
consumers and added a new one that uses the query
parameter `list_consumers=false` to skip listing
consumers for performance reasons.
This is done so as to fix dump errors coming in
deck when using gw 3.9+ where consumer-groups
do not show the associated consumers. We will
push the performant option behind a flag.

For: Kong/deck#1483
@Prashansa-K Prashansa-K mentioned this issue Jan 8, 2025
Merged
5 tasks
Prashansa-K added a commit to Kong/go-kong that referenced this issue Jan 13, 2025
@Prashansa-K @pmalek
fix: added new method to fetch a consumer-group without consumers. (#494
16fdf6e 
)

* fix: added new method to fetch a consumer-group without consumers.

Reverted the existing `Get` method to keep listing
consumers and added a new one that uses the query
parameter `list_consumers=false` to skip listing
consumers for performance reasons.
This is done so as to fix dump errors coming in
deck when using gw 3.9+ where consumer-groups
do not show the associated consumers. We will
push the performant option behind a flag.

For: Kong/deck#1483

* chore: added changelog update

* chore: improved test readability

* chore: fixed lint error

* chore: updated changelog file with change links

* Update CHANGELOG.md

Co-authored-by: Patryk Małek <[email protected]>

---------

Co-authored-by: Patryk Małek <[email protected]>
@Prashansa-K Prashansa-K mentioned this issue Jan 13, 2025
Merged
@Prashansa-K Prashansa-K mentioned this issue Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Prashansa-K Prashansa-K

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Prashansa-K