Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake error when building with external spdlog #399

Open
panicgh opened this issue Oct 20, 2024 · 1 comment
Open

CMake error when building with external spdlog #399

panicgh opened this issue Oct 20, 2024 · 1 comment

Comments

@panicgh
Copy link

panicgh commented Oct 20, 2024

When building with -DKOMPUTE_OPT_USE_SPDLOG:BOOL=TRUE -DKOMPUTE_OPT_USE_BUILT_IN_SPDLOG:BOOL=FALSE cmake outputs the error:

CMake Error at src/logger/CMakeLists.txt:59 (target_compile_definitions):
   Cannot specify compile definitions for target "spdlog" which is not built
   by this project.

because spdlog in https://github.com/KomputeProject/kompute/blob/187b84bd66b86ab64d26aa536d76f11f8c33fa1e/src/logger/CMakeLists.txt#L59C1-L59C111 is an external target, for which definitions cannot be set.

@axsaucedo
Copy link
Member

@panicgh the aim is to enable users that may have spdlog set up themselves to work, ie if you import spdlog in your cmakefile which would be external as opposed to using the one built-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants