Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] General caching issues #1019

Closed
jabby09 opened this issue Mar 19, 2023 · 6 comments · Fixed by #1099
Closed

[performance] General caching issues #1019

jabby09 opened this issue Mar 19, 2023 · 6 comments · Fixed by #1099
Assignees
Labels
enhancement New feature or request QA needed

Comments

@jabby09
Copy link
Member

jabby09 commented Mar 19, 2023

I recently reported an issue in discord after creating a listing the project title was missing.

Image

Turns out it was a caching issue.

Overall seeing some issues when creating/updating listings etc of the information not displayed correctly or very quickly on the frontend. This can lead to confusion since the user may not know they need to hard refresh multiple times to see changes.

As one example, when I create a new listing, sometimes it takes numerous refresh for the listing to show and if I change screens, like go to marketplace and then back to my profile my listing is not there until I refresh.

The other thing I often see (not a caching issue) is every time I click on my profile page the create listing button spinner shows for 8,10 or more seconds - what is causing that?

There are other issues already created around caching, i.e. #1008 and #1015 so clearly caching is a known issue. I'm not sure we can icebox this before launch but also not sure what the solution or level of effort would be to improve the UX.

@jabby09 jabby09 added the bug Something isn't working label Mar 19, 2023
@ladytrekker
Copy link
Contributor

As one example, when I create a new listing, sometimes it takes numerous refresh for the listing to show and if I change screens, like go to marketplace and then back to my profile my listing is not there until I refresh.

There is a loading spinner shown after you created or updated a listing
This is the indicator that the UI waits for the updated data on the backend.
No need to refresh anything while being on your own profile page.

Bildschirm­foto 2023-03-20 um 21 01 24

Bildschirm­foto 2023-03-20 um 21 02 21

After I created and updated a listing => I can find it on the marketplace overview page for all projects

Bildschirm­foto 2023-03-20 um 21 03 21

@ladytrekker
Copy link
Contributor

The other thing I often see (not a caching issue) is every time I click on my profile page the create listing button spinner shows for 8,10 or more seconds - what is causing that?

For me it doesn't take 8-10 seconds ... ?

Under the hood the client checks if:

  • does the user have assets attached? (data fetch from backend)
  • if so, does a corresponding project exist on backend? (data fetch from backend)
  • if not, can I get the data from the contract directly? (which asset token is this? which contract has to be created? => get the data)
  • does the data exist now? => enable the button and create the correct assets dropdown with the project data when the user creates a listing

@jabby09
Copy link
Member Author

jabby09 commented Mar 29, 2023

See KlimaDAO/bezos-frontend#434 for latest

@jabby09 jabby09 transferred this issue from KlimaDAO/bezos-frontend Apr 10, 2023
@jabby09 jabby09 moved this to In Test in Sprint Planning Apr 10, 2023
@jabby09 jabby09 added QA needed enhancement New feature or request and removed bug Something isn't working labels Apr 10, 2023
@ShimonD-KlimaDAO
Copy link

Single project page caching updates passed QA.
#1025

@ShimonD-KlimaDAO
Copy link

Portfolio data page looks good, except for two minor notes. See my comment in #1047
#1047 (comment)

@ShimonD-KlimaDAO
Copy link

#1099 passes QA. This concludes all caching PRs.

@github-project-automation github-project-automation bot moved this from In Test to Done in Sprint Planning Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QA needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants