Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Storage FileStreams not disposed #45

Open
Kitt3120 opened this issue Jul 22, 2022 · 0 comments
Open

[BUG] Storage FileStreams not disposed #45

Kitt3120 opened this issue Jul 22, 2022 · 0 comments
Labels
bug Something isn't working essential Features that are essential for the bot good first issue Good for newcomers

Comments

@Kitt3120
Copy link
Owner

Describe the bug
The current storage implementations do not dispose the used FileStreams. Missing using statements or Dispose/DisposeAsync calls.

To Reproduce
Steps to reproduce the behavior:

  1. Start bot
  2. A storage like PersistantStorage or ConfigStorage will load a file
  3. The file is still being used after loading into memory

Expected behavior
The FileStreams should be disposed.

Operating System (please complete the following information):

  • OS:
  • Windows
  • MacOS
  • Linux (Arch, 5.18.12-zen)
  • Dotnet version: 6.0
  • Branch used: main
@Kitt3120 Kitt3120 added bug Something isn't working good first issue Good for newcomers essential Features that are essential for the bot labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working essential Features that are essential for the bot good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant