Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump monty on next release and streamline as_dict #159

Open
rkingsbury opened this issue Aug 4, 2024 · 1 comment
Open

bump monty on next release and streamline as_dict #159

rkingsbury opened this issue Aug 4, 2024 · 1 comment
Assignees
@SuixiongTay
Labels
dependencies Pull requests that update a dependency file housekeeping

Comments

@rkingsbury
Copy link
Member

pyEQL has included custom code in Solution.as_dict to handle serialization of Quantity objects. I recently added support for Quantity directly to monty (which defines the MSONable class that we use). Once these changes are released (more recent than 2024.7.12), then we can bump the version in pyproject.toml and remove the custom Quantity code from as_dict
@rkingsbury rkingsbury added dependencies Pull requests that update a dependency file housekeeping labels Aug 4, 2024
@rkingsbury
Copy link
Member Author

FYI, it looks like the new monty release is out

https://github.com/materialsvirtuallab/monty/releases/tag/v2024.7.29

@rkingsbury rkingsbury mentioned this issue Aug 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuixiongTay SuixiongTay

Labels
dependencies Pull requests that update a dependency file housekeeping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkingsbury @SuixiongTay