Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: More than one input flow socket can be connected to the same output flow socket #17

Open
hybridherbst opened this issue Aug 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@hybridherbst
Copy link
Contributor

In this simple graph, only "world" is logged – my expectation is that "hello" and "world" are logged instead:

I could not find details in the spec on what happens when the same output flow socket is connected to multiple input flow sockets. I did find that there's a flow/sequence node but would not expect that to be necessary. My understanding is that the one value output can also be connected to multiple value inputs. cc @lexaknyazev, I might have missed a place where that is defined?

image
{
	"nodes": [
		{
			"type": "event/onStart",
			"values": [],
			"configuration": [],
			"flows": [
				{
					"id": "out",
					"node": 2,
					"socket": "in"
				},
				{
					"id": "out",
					"node": 1,
					"socket": "in"
				}
			],
			"metadata": {
				"positionX": "271.7791644049969",
				"positionY": "274.00562447450295"
			}
		},
		{
			"type": "ADBE/output_console_node",
			"values": [
				{
					"id": "message",
					"value": "world",
					"type": 7
				}
			],
			"configuration": [],
			"flows": [],
			"metadata": {
				"positionX": "806.8545094544273",
				"positionY": "474.4824028307539"
			}
		},
		{
			"type": "ADBE/output_console_node",
			"values": [
				{
					"id": "message",
					"value": "hello",
					"type": 7
				}
			],
			"configuration": [],
			"flows": [],
			"metadata": {
				"positionX": "808.3572132317787",
				"positionY": "185.60156250000006"
			}
		}
	],
	"variables": [],
	"customEvents": [],
	"types": [
		{
			"signature": "bool"
		},
		{
			"signature": "int"
		},
		{
			"signature": "float"
		},
		{
			"signature": "float2"
		},
		{
			"signature": "float3"
		},
		{
			"signature": "float4"
		},
		{
			"signature": "float4x4"
		},
		{
			"signature": "custom",
			"extensions": {
				"AMZN_interactivity_string": {}
			}
		}
	]
}
@hybridherbst
Copy link
Contributor Author

hybridherbst commented Aug 26, 2024

This works:
image

So

  • either the bug here is that all connected flows should be run,
  • or the bug is that I can connect the outputs to more than one thing at all,
  • and/or that there is no log telling me that I messed up.

@lexaknyazev
Copy link
Member

An output flow cannot be connected to more than one input flow.

To have multiple output ops from the same node, use flow/sequence or chain the out output flows.

@hybridherbst
Copy link
Contributor Author

Thank you for the clarification!
Could you point me at the part of the spec where this is stated? I wasn't able to find it.

@hybridherbst hybridherbst changed the title Bug: only the last connected flow node is executed instead of all connected flow nodes Bug: More than one input flow socket can be connected to the same output flow socket Aug 26, 2024
@lexaknyazev
Copy link
Member

It's impossible by design given the JSON structure like

  {
    "type": "event/onStart",
    "flows": [
      {
        "id": "out",
        "node": 0,
        "socket": "in"
      }
    ]
  }

and this spec language:

The same id value MUST NOT be used more than once within each of the configuration, values, and flows arrays.

An explicit note won't hurt, of course.

@mattmacf98 mattmacf98 added the bug Something isn't working label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@hybridherbst @lexaknyazev @mattmacf98 and others