Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec change] Fix contradiction with context constructors #947

Open
sycl-issue-bot bot opened this issue Sep 20, 2024 · 1 comment
Open

[Spec change] Fix contradiction with context constructors #947

sycl-issue-bot bot opened this issue Sep 20, 2024 · 1 comment

Comments

@sycl-issue-bot
Copy link

Please review whether KhronosGroup/SYCL-Docs#628 by @gmlueck requires any changes to the CTS.

If changes are required: Open a new PR addressing the changes and link it to this issue.
If no changes are required: Close this issue and proceed with the spec PR.

@gmlueck
Copy link
Contributor

gmlueck commented Sep 30, 2024

The CTS already has tests for most of the context constructors in KhronosGroup/SYCL-Docs#628, but we need new CTS tests for these overloads:

  • context(const platform &plt, const property_list &propList = {})
  • context(const platform &plt, async_handler asyncHandler, const property_list &propList = {})

There are no CTS tests the check for the case when the device list is empty. However, the CTS generally does not test error conditions, so it is not necessary to add these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant