Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should conformance_report.xml contain SYCL-CTS commit hash? #906

Open
KornevNikita opened this issue Jun 29, 2024 · 2 comments
Open

Should conformance_report.xml contain SYCL-CTS commit hash? #906

KornevNikita opened this issue Jun 29, 2024 · 2 comments

Comments

@KornevNikita
Copy link
Contributor

KornevNikita commented Jun 29, 2024 •
edited
Loading

As I see there are no mentions of the current SYCL-CTS commit hash in the report, so the developer have to check it by himself. But if one forgot to do this, looks like he has no chances then to define the exact version of the repo he used for this run.

Is it intended? Or should we update the script to include the hash?
@bader
Copy link
Contributor

bader commented Jun 29, 2024

This will certainly be a useful enhancement to the run_conformance_test.py script. I don't believe this functionality was omitted intentionally.

@KornevNikita
Copy link
Contributor Author

@bader I created a PR. Could you help with reviewing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bader @KornevNikita