Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpSpecConstantOp doesn't validate itself #5948

Open
spencer-lunarg opened this issue Jan 16, 2025 · 0 comments
Open

OpSpecConstantOp doesn't validate itself #5948

spencer-lunarg opened this issue Jan 16, 2025 · 0 comments

Comments

@spencer-lunarg
Copy link
Contributor

There is a stale PR attempt here #4907

Basically this (https://godbolt.org/z/v4Yfs91rP)

OpCapability Shader
OpCapability Linkage
OpMemoryModel Logical GLSL450
%uint = OpTypeInt 32 0
%float = OpTypeFloat 32
%uint_1 = OpConstant %uint 1
%float_1 = OpConstant %float 1
%good = OpSpecConstantOp %float QuantizeToF16 %float_1
%bad1 = OpSpecConstantOp %uint QuantizeToF16 %float_1
%bad2 = OpSpecConstantOp %float QuantizeToF16 %uint_1

should throw an error, but doesn't

We need a way for OpSpecConstantOp to be validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant