Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to switch to SPIR-V Tools format of text representation (assembly) #32

Open
AlexeySotkin opened this issue May 29, 2018 · 2 comments
Labels
enhancement New feature or request stale Old not addressed issues

Comments

@AlexeySotkin
Copy link
Contributor

It looks beneficial to have unified format.
This should also fix KhronosGroup/SPIRV-LLVM#199

@neildhickey
Copy link
Contributor

For this activity we'd need to switch to using the SPIR-V Tools In-memory format for representing the SPIR-V objects, then we can make calls directly into libspirv_tools to perform the toText serialization. We can also then standardise on other parts of the SPIRV-Tools repo, such as SPIR-V parsing.

I think it will entail reworking a lot of the classes in libSPIRV, Module, Function, BasicBlock etc to at least include the same implementation objects as the SPIRVTools repo, we could replace the existing classes with an adaptor of the SPIRVTools classes to allow the interface to SPIRVReader et al to be the same. This would at least allow work to continue on supporting Vulkan in parallel.

I expect about a month of work. We'd also need to modify the tests to use the new textual format.

@neildhickey neildhickey added the agenda Tooling Call Agenda label Jul 31, 2018
@AnastasiaStulova
Copy link
Contributor

OpenCL TSG call July 31:

  • Makes sense to keep API unchanged
  • Submodule might be a problem for adoption by LLVM but probably we have to worry about it later as there are not many other options for integrating external repos.

@AnastasiaStulova AnastasiaStulova removed the agenda Tooling Call Agenda label Aug 7, 2018
@AlexeySachkov AlexeySachkov added the enhancement New feature or request label Aug 29, 2019
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this issue Sep 1, 2022
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this issue Sep 1, 2022
…> 64bits (KhronosGroup#32)

In the LLVM IR if input is an integer with a width more than 64
bits the function will take this input through 'byval' pointer. If we
leave the translation as is it will violate the extension spec,
which says, that the input must by of an integer type. Add an
extra load to fix this.

Signed-off-by: Dmitry Sidorov <[email protected]>
@MrSidims MrSidims added the stale Old not addressed issues label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Old not addressed issues
Projects
None yet
Development

No branches or pull requests

5 participants