Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

공통 컴포넌트: Text #28

Merged
merged 4 commits into from
Jan 3, 2024
Merged

공통 컴포넌트: Text #28

merged 4 commits into from
Jan 3, 2024

Conversation

bottlewook
Copy link
Collaborator

@bottlewook bottlewook commented Jan 3, 2024 •
edited
Loading

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • FIX : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • STYLE : 코드 스타일에 관련된 변경 사항
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • CHORE : 패키지 매니저 설정, 코드 수정 없이 설정 변경(eslint) 등 기타 사항

설명

Key Changes

  1. Text 컴포넌트 제작
  2. Text 컴포넌트 스토리북 제작
  3. PR 템플릿에 test 추가

How it Works

  1. Text 컴포넌트의 props는 아마 스토리북 보시면서 이해하는 게 빠르실 거에요!
    제가 내일 다시 설명드릴게요~

To Reviewers

  • Spacing 컴포넌트 cherry pick 한 커밋이 있어서 중복되는 코드가 조금 있어요~

@bottlewook bottlewook added ✨ Feature 기능 개발 ✅ Test test 관련(storybook, jest...) labels Jan 3, 2024
@bottlewook bottlewook self-assigned this Jan 3, 2024
@bottlewook bottlewook linked an issue Jan 3, 2024 that may be closed by this pull request
공통 컴포넌트: Text 제작 #27
Closed
2 tasks
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
f1-wash-pedia-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 4:02pm

seoye0ng
seoye0ng approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@seoye0ng seoye0ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 고생하셨습니다!🙂

@bottlewook bottlewook changed the title 공통 컴포넌트: Text 제작 공통 컴포넌트: Text Jan 3, 2024
@bottlewook bottlewook merged commit 3044196 into develop Jan 3, 2024
4 checks passed
@bottlewook bottlewook deleted the common-component-text branch January 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seoye0ng seoye0ng seoye0ng approved these changes

Assignees

@bottlewook bottlewook

Labels
✨ Feature 기능 개발 ✅ Test test 관련(storybook, jest...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

공통 컴포넌트: Text 제작
2 participants
@bottlewook @seoye0ng