Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.0: BreakTimeCheckToolGER.php does not handle $timesheet->getEnd() == null #69

Closed
fnatter2 opened this issue Jan 22, 2025 · 2 comments

Comments

@fnatter2
Copy link

Dear developer,

many thanks for the useful plugin!

We found out that v2.2.0 does not handle the case where a recording is in progress
($timesheet->getEnd() == null) in at least two places of BreakTimeCheckToolGER.php.

We tried to fix it like this (sorry for missing context, can provide this later if necessary;
it was in function something like "check6hours"):

    // hack 21.1.25
	    if($timesheet->getEnd() == null) {
	    	continue;
--
		// hack 21.1.25
                if ($value[$i]->getEnd() != null && $value[$i + 1]->getEnd() != null) {

Could you please fix this?

Many Thanks and Best Regards!
Felix

@fnatter2
Copy link
Author

It was in checkSixHoursWithoutBreak() and checkElevenHoursBreak()

@KatjaGlassConsulting
Copy link
Owner

Thanks for finding this, I know the context and will fix it soon within a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants