Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kavita epub reader yomitan tapping/mobile highlight issue #3521

Open
scare376 opened this issue Jan 29, 2025 · 0 comments
Open

Kavita epub reader yomitan tapping/mobile highlight issue #3521

scare376 opened this issue Jan 29, 2025 · 0 comments
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@scare376
Copy link
Collaborator

What happened?

Yomitan is a extension for chrome and firefox that allows you to lookup words/characters in installed dictionaries. It does this by pressing a hotkey while hovering over the word/character or if on a touchscreen compatible device by tapping on it. This will highlight the word and show a popup for the dictionary. On desktop this works fine. When you hold the hotkey and hover over a word it highlights you release and click off to the side the popup disappears. On mobile if you tap on the word and it highlights but when you tap away to dismiss it the kavita highlight banner appears. You then have to tap to dismiss the banner and tap one more time to dismiss the popup.
I was able to reproduce this on desktop in chrome by turning on device emulation.

chrome_YuDmCtwZuU.mp4

Steps to reproduce (in chrome) (steps also work on mobile with firefox extension link can be found on yomitan.wiki or kiwi browser which uses the chrome extension)

  1. Add https://chromewebstore.google.com/detail/yomitan-popup-dictionary/likgccmbimhjbgkjambclfkhldnlhbnn
  2. After extension is installed a Welcome to Yomitan! page should open. Click on Get recommended dictionaries.
  3. Download Jitendex or KANJIDIC.
  4. Go to kavita
  5. Open a japanese epub and navigate to a page with a lot of text (message me if one is needed)
  6. Open dev console and turn on device emulation.
  7. "tap" (click) on characters until one highlights and the dictionary popup appears.
  8. tap away from the box and the highlighted word. banner should appear. popup stays up.
  9. tap again. banner should disappear. popup stays up.
  10. tap again. popup disappears.

What did you expect?

It shouldn't take 4 taps to do the lookup and dismiss the popup. Everywhere else its tap to lookup. tap to dismiss

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

Nightly Testing Branch

What operating system is Kavita being hosted from?

Docker (Dockerhub Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

If the issue is being seen on Mobile, what OS are you running where you see the issue?

Android

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

Firefox

Relevant log output

Additional Notes

No response

@scare376 scare376 added the needs-triage Needs to be triaged by a developer and assigned a release label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
None yet
Development

No branches or pull requests

1 participant