Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference cycles are not detected or handled during load and policy scans #6

Open
andylowry opened this issue Sep 18, 2018 · 0 comments
Open

Reference cycles are not detected or handled during load and policy scans #6

andylowry opened this issue Sep 18, 2018 · 0 comments

Comments

@andylowry
Copy link
Contributor

Cycles cannot affect component scans
andylowry added a commit that referenced this issue Sep 19, 2018
@andylowry
[#6] Added callback capability to JsonStateWalker
6f172ab 
Also reworked terminology so that "walk" now refers to what the walker
does to the tree as a whole or to container nodes within it, while
"visit" is used for what happens to each node included in the walk.

The Disposition class for the result of a visit now includes an optional
Callback metnod instance, which will be invoked just prior to finishing
up the visit. This means that the walk method can do something while
visiting a container node and then undo it after all its children have
been visited.

We'll use that for managing a set of references already encountered in
this walk while visiting an ancestor node, in order to support reference
cycle detection.
andylowry added a commit that referenced this issue Sep 19, 2018
@andylowry
[#6] Fix incorrect walk logic
bac0cb4 
We need to descend into child nodes of the current node, even if we're
not actually visiting the current node because we're in an anonymous
state. After all, anonymous states appear becuase they're intermediate
states in transits that lead to named nodes, so not descending in this
case could mean failing to visit some nodes corresponding to named states.
andylowry added a commit that referenced this issue Sep 19, 2018
@andylowry
[#6] Introduce CycleDetector class and tests
f120811 
Will use this class to detect reference cycles during scans.
andylowry added a commit that referenced this issue Sep 20, 2018
@andylowry
[#6] Added callback test to walker tests
b538ac5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andylowry