Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimals aren't supported #44

Closed
andstor opened this issue Sep 17, 2019 · 4 comments · Fixed by #45
Closed

Decimals aren't supported #44

andstor opened this issue Sep 17, 2019 · 4 comments · Fixed by #45
Labels
enhancement New feature or request important This issue is important js JavaScript

Comments

@andstor
Copy link
Member

andstor commented Sep 17, 2019

Decimals aren't supported.
Both decimal point . and comma , should be supported.

This means that they needs to be defined as accepted tokens, see tokens.js. Further, they need to be parsed as being a part of a number. This should most likely be implemented in the parseNumber function in the parser.js file.

@andstor andstor added enhancement New feature or request js JavaScript important This issue is important labels Sep 17, 2019
@andstor andstor changed the title Desimals aren't supported. Desimals aren't supported Sep 17, 2019
@andstor andstor changed the title Desimals aren't supported Decimals aren't supported Sep 20, 2019
@andstor
Copy link
Member Author

andstor commented Sep 21, 2019

Maxima only accepts decimal points ..
Allowing for comma decimal separator will make interpretation of some expressions VERRY difficult.

We should therefore only allow for decimal points . in decimal numbers / floating numbers.

@andstor
Copy link
Member Author

andstor commented Sep 21, 2019

Should we allow writing numbers with a leading decimal point?
For example: .025

@andstor
Copy link
Member Author

andstor commented Sep 21, 2019

I decided not to allow for numbers with a leading decimal point. Although, this is a quick fix if we change our mind later.

@andstor
Copy link
Member Author

andstor commented Oct 26, 2019

Maxima only accepts decimal points ..
Allowing for comma decimal separator will make interpretation of some expressions VERRY difficult.

We should therefore only allow for decimal points . in decimal numbers / floating numbers.

For future notice, it is mainly sets and lists that are difficult to interpret when allowing decimal commas , in floating numbers. Here, commas , needs to be used for separating the entries in the set/list. Note that sets and lists aren't implemented yet, but may be in the future (see #47 and #48).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important This issue is important js JavaScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant