New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the signal-slot connections #16

Open

KGergo88 opened this issue Jan 20, 2019 · 0 comments

Labels

Owner

KGergo88 commented Jan 20, 2019 •

edited

Loading

As a developer I would like to have easily understandable signal interfaces.

Now the signal and slot names are similar but not necessarily the same which can lead to misunderstandings.

Ideas:

Maybe you could inherit the inteface classes (removing the "signal" and add them as public functions in the interfaces) by the emitter and the reciever as well and so both sides would be forced to use the same set of functions
The GuiInterface's StartsToRun and ShuttingDown signals are not used at the moment, that needs to be implemented
Some slots could be replaced with lambda functions which would lead to less class members

KGergo88 added the enhancement label

KGergo88 changed the title ~~TODO: Review the signal-slot connection and names~~ TODO: Review the signal-slot connections

KGergo88 changed the title ~~TODO: Review the signal-slot connections~~ Review the signal-slot connections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment