Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untested test based on Julia version #107

Open
gbruer15 opened this issue Apr 29, 2024 · 3 comments
Open

Untested test based on Julia version #107

gbruer15 opened this issue Apr 29, 2024 · 3 comments

Comments

@gbruer15
Copy link
Contributor

The test case based on complexexample_pre_1_9.txt is not run in the CI. This makes it easy to accidentally merge a pull request that breaks for Julia 1.8.

Would it make sense to add Julia 1.8 to the CI workflow?

@oxinabox
Copy link
Member

Does it not get caught by our CI for 1.0 and 1.6?

@gbruer15
Copy link
Contributor Author

I don't think so. Here is the relevant test code:

@testset "Complex Example" begin
test_file = if VERSION >= v"1.9.0-beta4.29" # https://github.com/JuliaLang/julia/pull/48526
"references/complexexample.txt"
elseif VERSION >= v"1.7.0"
"references/complexexample_pre_1_9.txt"
else
"references/complexexample_pre_1_7.txt"
end
@test_reference test_file read(`$(Base.julia_cmd()) $(@__DIR__)/example.jl`, String) |> clean_output
end

There's complexexample.txt for Julia version 1.9 and complexexample_pre_1_7.txt for version < 1.7, which leaves complexexample_pre_1_9.txt for Julia 1.7 and 1.8.

@oxinabox
Copy link
Member

oxinabox commented May 1, 2024

ok, we probably should add CI for 1.8 to catch that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants