You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but unfortunately i've upwards of 20 modules and a few hundred files in which these export statements could be living, and given some of the generic names (e.g. :compile) it takes more than a simple grep to find the offending lines.
I wonder if we could instead be printing out at least which module has the undefined export?
e.g. perhaps just as simple a change as pushing the module name along with the undefined name?
--- a/src/exports.jl+++ b/src/exports.jl@@ -13,13 +13,13 @@ function walkmodules(f, x::Module)
end
"""
- undefined_exports(m::Module) :: Vector{Symbol}+ undefined_exports(m::Module) :: Vector
"""
function undefined_exports(m::Module)
- undefined = Symbol[]+ undefined = Any[]
walkmodules(m) do x
for n in names(x)
- isdefined(x, n) || push!(undefined, n)+ isdefined(x, n) || push!(undefined, (x, n))
end
end
return undefined
The text was updated successfully, but these errors were encountered:
I'm trying using Aqua.jl for the very first time. Thanks for creating it!
I ran
test_undefined_exports
on a large codebase with many submodules, and got a test failure with message:but unfortunately i've upwards of 20 modules and a few hundred files in which these
export
statements could be living, and given some of the generic names (e.g.:compile
) it takes more than a simple grep to find the offending lines.I wonder if we could instead be printing out at least which module has the undefined export?
e.g. perhaps just as simple a change as pushing the module name along with the undefined name?
The text was updated successfully, but these errors were encountered: