From f0ecb57fc31bcfa9113b0622205b48b25e809206 Mon Sep 17 00:00:00 2001 From: Sambit Kumar Dash Date: Thu, 10 Aug 2017 20:05:10 +0530 Subject: [PATCH] Add libc-bin to library aliases (#19) Fixes library dependency on Ubuntu 17.04. --- README.md | 4 ++++ deps/build.jl | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index dbbc006..41a7f95 100644 --- a/README.md +++ b/README.md @@ -149,3 +149,7 @@ julia> readstring(s) # Decoding happens automatically here Do not forget to call `close` on `StringEncoder` and `StringDecoder` objects to finish the encoding process. For `StringEncoder`, this function calls `flush`, which writes any characters still in the buffer, and possibly some control sequences (for stateful encodings). For both `StringEncoder` and `StringDecoder`, `close` checks that there are no incomplete sequences left in the input stream, and raise an `IncompleteSequenceError` if that's the case. It will also free iconv resources immediately, instead of waiting for garbage collection. Conversion currently raises an error if an invalid byte sequence is encountered in the input, or if some characters cannot be represented in the target enconding. It is not yet possible to ignore such characters or to replace them with a placeholder. + +## Notes on Installation on Linux OS + +Most Linux distributions provide `iconv` functionalities as part of the base operating system library `glibc`. In normal circumstances, no additional installation of `libiconv` should be required. If you observe such a behavior on your operating system, file an issue with OS details. diff --git a/deps/build.jl b/deps/build.jl index 7a06b90..6714384 100644 --- a/deps/build.jl +++ b/deps/build.jl @@ -31,7 +31,7 @@ function validate_iconv(n, h) return ret == -1 % Csize_t && Libc.errno() == Libc.EILSEQ end -libiconv = library_dependency("libiconv", aliases = ["libc", "iconv"], +libiconv = library_dependency("libiconv", aliases = ["libc", "libc-bin", "iconv"], validate = validate_iconv) if is_windows()