Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the GARCH implementation #53

Open
Teo-ShaoWei opened this issue Oct 19, 2015 · 3 comments
Open

Upgrade to the GARCH implementation #53

Teo-ShaoWei opened this issue Oct 19, 2015 · 3 comments

Comments

@Teo-ShaoWei
Copy link

Hi,

I refer to AndreyKolev/GARCH.jl#4. I am using GARCH in my program, and performed some upgrade to it. Would it be alright if I perform a pull request here?

This is my first attempt to contribute to open source, so any advice is very much appreciated too.

@milktrader
Copy link
Contributor

Yes, your PR is welcome!

@GordStephen
Copy link
Contributor

👍 Also, if you have any tests (or would be willing to write some) that would be very welcome as well, as we currently don't have any for the GARCH model.

@Teo-ShaoWei
Copy link
Author

Thanks alot for the welcome =) I will attempt to upgrade it step by step. Meanwhile I will open a pull request first so we can see the changes as it come in. If there is any changes that is not good, feel free to inform me early so we can deliberate on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants