Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alias_sample! can be faster #916

Closed
adienes opened this issue Feb 1, 2024 · 0 comments · Fixed by #927
Closed

alias_sample! can be faster #916

adienes opened this issue Feb 1, 2024 · 0 comments · Fixed by #927

Comments

@adienes
Copy link

adienes commented Feb 1, 2024

https://github.com/JuliaStats/StatsBase.jl/blob/77e63df55233d9fc3119bd10144d5b8cc1b9f0ad/src/sampling.jl#L729C9-L729C54

by changing that to ifelse, a la JuliaStats/Distributions.jl#1831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a faster and safer implementation of alias_sample! LilithHafner/StatsBase.jl
1 participant
@adienes