-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'dataset' suddenly stopped working with 'ISLR' #117
Comments
I suppose I have a similar problem. I tried to execute
but
|
Thanks. Students seem to suddenly have this problem even on (ISLR) datasets which have previously worked fine with exactly the same syntax |
I assume this is caused by FileIO 1.6.0 which was a major rewrite of FileIO (but supposed to be non-breaking - maybe RDatasets uses some internals of FileIO?). Downgrading to FileIO 1.5 fixed e.g. problems with CairoMakie for me (MakieOrg/Makie.jl#864). |
Can confirm your solution works @devmotion ❤️ |
BTW since I haven't investigated what the actual problem is I am not sure if it is a problem of RDatasets or rather of RData. |
The error message that I get when running the |
Fixes #225 Fixes #32 xref JuliaStats/RDatasets.jl#117
Really sorry about this, and especially about messing up your class, @compleathorseplayer. Calling it FileIO 1.6 rather than FileIO 2.0 seems to be one of the biggest Julia mistakes I've ever made. I thought I had so cleverly made the rewrite backwards-compatible. This should be fixed in FileIO 1.6.1. For the interested, there's a more detailed explanation in JuliaIO/FileIO.jl#308 (comment). That said, the solution in #119 is worth considering independently on its own merits. |
Thanks, Tim. If students re-install RDatasets, will this automatically be fixed now? If not (assuming some of them are barely computer-literate) what is the easiest way to fix this? |
All they should have to do is |
Thanks for that. I don't know if they want to upgrade everything (at this point, I don't want to risk other new bugs!). How do they just upgrade this package? |
I can understand that! 😅 Nominally |
I teach a class using ISLR, helped by the RDatasets package, which has worked fine this semester so far, until in the past few days, it suddenly stopped working for my students. For all the invocations of
They are getting
I emphasise that these were scripts that worked fine before, and suddenly just stopped working.
Does anyone have any ideas as to why this might be happening and how one might fix it?
The text was updated successfully, but these errors were encountered: