Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isotonic Regression question #206

Open
FatemehTahavori opened this issue Nov 9, 2022 · 1 comment
Open

Isotonic Regression question #206

FatemehTahavori opened this issue Nov 9, 2022 · 1 comment

Comments

@FatemehTahavori
Copy link

Hi,
I have generated a synthetic dataset in python and compared python implementation of Isotonic Regression (scikit-learn) vs julia (MultivariateStats.jl).
The python script is : https://gist.github.com/FatemehTahavori/4885a1bb1a9fa2162d0044989d233e0a.js
The Julia script is: https://gist.github.com/FatemehTahavori/158b0501545875861064192290516ed0.js
Outputs do not seem to match using same dataset, I know there are different implementations of Isotonic Regression, I was wondering which implementation is used in MultivariateStats? and if this difference is because of that?
Thanks

@wildart
Copy link
Collaborator

wildart commented Nov 15, 2022

I implemented PAV algorithm from Best, M.J., Chakravarti, N. Active set algorithms for isotonic regression; A unifying framework. Mathematical Programming 47, 425–439 (1990).

As I recall, sk-learn implementation outputs response values for every regressors, but Julia's implementation outputs a model - a piecewise linear function bounds with values.

The implementation may need a review as I implemented it differently and more efficiently second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants