Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using truncated SVD for whitening in ICA gives 5-10x speedup on large inputs #119

Open
ghost opened this issue May 4, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented May 4, 2020

Using truncted SVD for whitening gives huge speedup for me, could be done by replacing the following code:

        Efac = eigen(C)
        ord = sortperm(Efac.values; rev=true)
        (v, P) = extract_kv(Efac, ord, k)

with P, v, _ = tsvd(C, k)

@ghost ghost changed the title using truncated SVD for whitening gives 5-10x speedup on large inputs using truncated SVD for whitening in ICA gives 5-10x speedup on large inputs May 4, 2020
@wildart
Copy link
Collaborator

wildart commented May 5, 2020

Too bad, that tsvd doesn't follow LinearAlgebra interface by returning SVD object. It's a good that you mention a possibility of other eigendecomposition methods. But, it would require to rewrite API to abstract eigendecomposition part of the package. I have a long standing plan to revise the package interface, see #94. I'll definitely consider this issue during the rewrite.
As of a time horizon, can't say anything at this point.

@wildart wildart mentioned this issue May 5, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant