You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are still using this quite heavily in Oscar land, but after playing around with https://github.com/JuliaTesting/Aqua.jl (which helps detecting method ambiguities), I noticed that RandomExtensions.jl leads to a lot of method ambiguities. For example, the methods
One problem with these methods in "containers.jl" is that they are doing type piracy, so the plan is to split the bulk of this package into a non-pirating part, which Oscar could be updated to depend on (last time I checked, Oscar was not depending on methods defined in this file).
We are still using this quite heavily in Oscar land, but after playing around with https://github.com/JuliaTesting/Aqua.jl (which helps detecting method ambiguities), I noticed that RandomExtensions.jl leads to a lot of method ambiguities. For example, the methods
will make the pass-through methods
ambiguous for certain input types (note that I cannot pin down the type of
v
directly, sinceT
is abstract and there are many possible combinations).They are usually fine in practice, but it just looks bad. There are so many, that ignoring them might hide real ambiguities.
The text was updated successfully, but these errors were encountered: